search

Turbo87 / aerofiles

waypoint, task, tracklog readers and writers for aviation
http://aerofiles.readthedocs.org/
MIT License
45 stars 27 forks source link

299 datetime.datetime timestamps tz aware #302

Closed sylvainvdm closed 1 month ago

sylvainvdm commented 2 months ago

Fixes #299

bubeck commented 1 month ago

Thanks for your PR. I am working on it now. I changed it to be Python 2/3.0 compatible. Also I decided to go for an additional key called "datetime" to store a datetime.datetime (including TZ=UTC) and "datetime_local" with TZ from HFTZN to not break compatibiliy. I will make merge soon with 1-2 days.

bubeck commented 1 month ago

Your PR has been adopted and merged. Please let me know. Then I will release as v1.4.0

sylvainvdm commented 1 month ago

Thanks for your PR. I am working on it now. I changed it to be Python 2/3.0 compatible. Also I decided to go for an additional key called "datetime" to store a datetime.datetime (including TZ=UTC) and "datetime_local" with TZ from HFTZN to not break compatibiliy. I will make merge soon with 1-2 days.

Looks good! Agree that your implementation is preferred.

For next time, feel free to edit my branches. For me it feels nice to have my contributions showing up in the github repo :)

bubeck commented 1 month ago

Yes, I will. Looking forward for new contributions from you! :-)