Turbo87 / intellij-emberjs

Ember.js support for JetBrains IDEs (IntelliJ, WebStorm, ...)
Apache License 2.0
217 stars 33 forks source link

Replace usage of internal IntelliJ APIs #496

Open Turbo87 opened 11 months ago

Turbo87 commented 11 months ago

I've received the following email from JetBrains:

Dear Tobias,

The latest updates of your plugin use the API annotated with org.jetbrains.annotations.ApiStatus.Internal. Private APIs like these should not be used outside of the IntelliJ Platform, as they might be renamed, changed, or removed in future versions.

Please replace these internal API usages in your future updates. You can refer to this article to find a recommended replacement API. If the API in question is not listed there, please create an issue, and we will help you to find the replacement API.

Let us know if you have any additional questions.

Kind regards, Your JetBrains Marketplace team

One usage of internal IntelliJ APIs I have found is: https://github.com/Turbo87/intellij-emberjs/blob/c6337fc2e0d78e7bf52f68ab612a1cf5ef31aa9f/src/main/kotlin/com/emberjs/cli/EmberCliProjectConfigurator.kt#L131

Unfortunately, I won't have time in the near future to work on these things myself. If anyone has time to fix this please open a pull request! :)

Tolke commented 9 months ago

Hello @Turbo87 , I love to help with this issue (and others). Sadly I am new about working with Intelijj Plugins, can you help me about set up the project? I already forked your repo. Just some basic info to start development.

Thanks !

Turbo87 commented 9 months ago

you can find the IntelliJ documentation at https://plugins.jetbrains.com/docs/intellij/welcome.html and you can use ./gradlew runIde to open the IDE with the local plugin installed

dwickern commented 6 months ago

There's one more internal API here:

'getModuleFile()' is marked unstable with @ApiStatus.Internal https://github.com/Turbo87/intellij-emberjs/blob/a580e01a91bbe0a60939be36346c934f9c66b866/src/main/kotlin/com/emberjs/configuration/EmberCommandLineState.kt#L20