Turbo87 / utm

Bidirectional UTM-WGS84 converter for python
http://pypi.python.org/pypi/utm
MIT License
486 stars 101 forks source link

Implement NumPy support (take 2) #30

Closed astrojuanlu closed 7 years ago

astrojuanlu commented 7 years ago

This PR supersedes #24.

I just took @TheBB commit and improved the .travis.yml script to provide code coverage using Codecov and two paths, with and without NumPy. For instance, you can see here that only the NumPy path is being tested:

https://codecov.io/gh/Juanlu001/utm/src/numpy/utm/conversion.py#L5

The other things is that now the tests require NumPy, so I was not sure on how to proceed here. I will wait for your comments :)

TheBB commented 7 years ago

Thanks for this! I have updated my previous PR with test that should work if numpy is not available, and also rebased on master. If you rebase your commits on top of that it should be good (and you'll avoid that merge commit, too).

codecov[bot] commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4c7c13f). Click here to learn what that means. The diff coverage is 95.91%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #30   +/-   ##
========================================
  Coverage          ?   92.2%           
========================================
  Files             ?       3           
  Lines             ?     154           
  Branches          ?       0           
========================================
  Hits              ?     142           
  Misses            ?      12           
  Partials          ?       0
Impacted Files Coverage Δ
utm/conversion.py 92% <95.91%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c7c13f...b88f575. Read the comment docs.

astrojuanlu commented 7 years ago

Thanks @TheBB! The history is much cleaner now. However, there are still some failures (I recall seeing force_zone_letter somewhere, but it got lost...!) so I gave you push access to my fork in case you want to fix them.

astrojuanlu commented 7 years ago

Closing this in favor of #24 again.