Open zplett opened 6 years ago
Merging #35 into master will decrease coverage by
1.87%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 95% 93.12% -1.88%
==========================================
Files 3 3
Lines 160 160
==========================================
- Hits 152 149 -3
- Misses 8 11 +3
Impacted Files | Coverage Δ | |
---|---|---|
utm/conversion.py | 92.94% <100%> (-1.93%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update efdd46a...b6c1f9f. Read the comment docs.
Prior to this change, when converting from latitude and longitude to utm, if the coordinate's native utm zone is on one hand of the equator and the user tried to force it into a utm zone across the equator, the library wasn't adding 10000000 to the northing value as it should since it was only doing that for negative latitude values. Similarly if a coordinate started in the southern hemisphere in latitude and longitude, and was coerced to the northern hemisphere, the northing would have 10000000 added to its value which isn't what should happen. Fixed this issue by changing:
elif negative(latitude): northing += 10000000
to:elif zone_letter <= "M": northing += 10000000