Turbo87 / utm

Bidirectional UTM-WGS84 converter for python
http://pypi.python.org/pypi/utm
MIT License
486 stars 101 forks source link

Add zone_letter_to_central_latitude #41

Open LuxMiranda opened 5 years ago

LuxMiranda commented 5 years ago

I'm working on a project involving zone centroids, so I figured I'd implement the sister function to zone_number_to_central_longitude.

Implements the special case of zone X being 4 degrees taller than the other latitude bands.

Turbo87 commented 5 years ago

@JackMiranda thanks! can you make sure to write a few tests for this new function too?

LuxMiranda commented 5 years ago

@JackMiranda thanks! can you make sure to write a few tests for this new function too?

Totes my goats my dude

codecov[bot] commented 5 years ago

Codecov Report

Merging #41 into master will increase coverage by 0.29%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage      95%   95.29%   +0.29%     
==========================================
  Files           3        3              
  Lines         160      170      +10     
==========================================
+ Hits          152      162      +10     
  Misses          8        8
Impacted Files Coverage Δ
utm/conversion.py 95.18% <100%> (+0.3%) :arrow_up:
utm/__init__.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d21fbbc...2d1edff. Read the comment docs.

LuxMiranda commented 5 years ago

This new commit does a few things:

Note: the Travis build only seems to fail as the build system itself fails when trying to fetch older python version archives.

LuxMiranda commented 5 years ago

In this commit, I've gone ahead and tidied up .travis.yml. I toyed around with it in a separate branch; both builds for Python 3.3 and Python 2.6 failed for some dependency reasons even with manual tweaking. Not surprising since they're both past end-of-life and the dependencies have already dropped support for them.

I also added testing for Python 3.7.

LuxMiranda commented 5 years ago

bump

Turbo87 commented 5 years ago

both builds for Python 3.3 and Python 2.6 failed for some dependency reasons even with manual tweaking. Not surprising since they're both past end-of-life and the dependencies have already dropped support for them.

unfortunately that means that this is a breaking change and requires a major version bump. apparently maintainers in the python ecosystem seem to not care about semver that much which is why some of our dependencies are breaking, even though they didn't have a major version bump...

would it be possible to restrict the breaking deps to versions that are still compatible with these old Python versions?

in any case, these changes are unrelated to the proposed functionality in this PR, so it would be great if you could move the Travis changes to a dedicated PR.