search

Turbo87 / webpack-notifier

webpack + node-notifier = build status system notifications
ISC License
306 stars 41 forks source link

Add option to change build Success message #25

Closed bokswagen closed 3 years ago

Turbo87 commented 7 years ago

@bokswagen may I ask why you want to modify the message?

bokswagen commented 7 years ago

When you have multiple webpack configs running, it's good to know which ones changed

Turbo87 commented 7 years ago

wouldn't it be better in that case to prefix it with the project name automatically instead of manually having to set the message? with the proposed solution you still don't know which project the notification is coming from if the build fails

Gvozd commented 3 years ago

I find the title to be a suitable (and sufficient) place to set the project name

Also, this PR looks incomplete, because you can customize the message only for a successful build, but not for warnings/errors But if you change them, then the configuration will unnecessarily increase. It may be worth changing the message with a function, by analogy with dynamic headers, but I'm not sure yet about this need

For this reason, I am closing this OL