search

Turbo87 / webpack-notifier

webpack + node-notifier = build status system notifications
ISC License
306 stars 41 forks source link

Avoiding undefined issue #3

Closed kentcdodds closed 9 years ago

kentcdodds commented 9 years ago

If the options excludeWarnings and the stats.hasWarnings() then error will be undefined and you get an error which breaks your build.

Turbo87 commented 9 years ago

aaargh, right... thanks!

Turbo87 commented 9 years ago

but I think we could just use:

} else {
    return;
}
kentcdodds commented 9 years ago

:+1:

kentcdodds commented 9 years ago

Feel free to close the PR and just push your own changes.

Turbo87 commented 9 years ago

should be published to npm in a few seconds once TravisCI has finished building