Turbo87 / webpack-notifier

webpack + node-notifier = build status system notifications
ISC License
306 stars 41 forks source link

Remove SnoreToast message from notification in Windows 10 #64

Closed Nothing-Works closed 3 years ago

Nothing-Works commented 3 years ago

Snoretoast is always added to the start menu as a shortcut and creates a registry key which is very annoying. Untitled This is an issue from node-notifier

To fix this we need to pass appID, can we do this in this library?

I am not using webpack-notifier directly, I am using laravel-mix and it uses this library for notification. Here is the issue. What's the easiest thing to do?

Update: after reading the source code seems like that I can just past the object into WebpackNotifierPlugin like this?

WebpackNotifierPlugin({
   appID: 'fooBar'
});

Will this do the right thing?

Gvozd commented 3 years ago

Yes, such transfer as a parameter is allowed You only need to write new WebpackNotifierPlugin of course

Covered with tests

I also planned to add an alternative way of setting options in the future - #65

new WebpackNotifierPlugin ({
  notifier: 'NotificationCenter',// or constructor - require('node-notifier').NotificationCenter
  notifierOptions: {
    withFallback: false,
    customPath: undefined
  },
  notifyOptions: {
    appId: 'com.squirrel.your.app'
  }
});
Nothing-Works commented 3 years ago

@Gvozd I like the solution you proposed #65, it's very flexible, clear and I know what's happening also feels more like the node-notifier native api.

Gvozd commented 3 years ago

@Nothing-Works, Wonderful!)

In the meantime, this solution is not ready, you can use the method you already found I will maintain backward compatibility with it throughout the current major release.