[wip] passing `node-notifier` options

Turbo87 / webpack-notifier

webpack + node-notifier = build status system notifications

ISC License

306 stars 41 forks source link

[wip] passing `node-notifier` options #65

Open Gvozd opened 3 years ago

Gvozd commented 3 years ago

[ ] testing direct passing otpions
[ ] document it

[ ] support custom sub-options like

new WebpackNotifierPlugin ({
notifier: 'NotificationCenter',// or constructor - require('node-notifier').NotificationCenter
notifierOptions: {
withFallback: false,
customPath: undefined
},
notifyOptions: {
appID: 'com.squirrel.your.app'
}
});

Nothing-Works commented 3 years ago

@Gvozd maybe just one little thing, I think you should consider user appID as the key rather than appId as appID is matching the exact key from node-notifier. see here

Gvozd commented 3 years ago

@Nothing-Works Yes, I sealed of course the appID is correct

corrected the test