search

TurboPack / MustangpeakVirtualshellTools

Delphi and CBuilder Components to create Explorer type programs
Other
49 stars 24 forks source link

Fix paths in JAM-VT packages #27

Open luebbe opened 2 years ago

luebbe commented 2 years ago

as mentioned in #26, the paths in the JAM-VT packages are wrong

romankassebaum commented 2 years ago

I do not understand. What do you want to fix?

luebbe commented 2 years ago

Try to compile the JAM-VT packages as they are now. The paths are wrong. Presumably the .dpk files were moved to a different folder and now all the relative paths are missing a "..\"

romankassebaum commented 2 years ago

But why should I fix the JAM-VT packages here in VirtualShellTools? And BTW, I do not have access to JAM-VT.

luebbe commented 2 years ago

You leave me puzzled. The JAM-VT Package for MustangPeakVirtualshellTools is part of the MustangPeakVirtualshellTools project. Where else would you fix it? If you have write access to the MustangPeakVirtualshellTools repo, you can merge the PR. @pyscripter was the last person to chane somethin in these .dpk files. He added libsuffix auto.

romankassebaum commented 2 years ago

Now I got it. This guy has added new packages. I had no idea.

Now I'm considering what to do. Maintaining two packages is normally nonsense. I'm thinking...

luebbe commented 2 years ago

If it should still be possible to build VirtualshellTools either with TP-VT or JAM-VT, you need to support either two packages or have two configurations in one package and IFDEF the bits in the .dpk file. Assuming that the package may be moved around, and that all other parameters will probably stay the same in the future, option b is probably less work in the long term.

luebbe commented 2 years ago

I tried to used {$IFDEF JAM_VT} in the required clause in the Alexandria package, but couldn't get it to work. I have the impression that only RELEASE and DEBUG configurations are supported in .dpk files.

romankassebaum commented 2 years ago

Have you tried a .inc file?