TurboPack / Orpheus

Orpheus is an award-winning UI toolkit for Embarcadero Delphi & C++Builder
Other
99 stars 36 forks source link

Cannot install Orpheus in C++ Builder 10.3 #14

Closed oliverClimbs closed 3 years ago

oliverClimbs commented 5 years ago

I understand that this release is for 10.2.3. Is there an estimated date for availability for 10.3? Currently I get the following error when trying to install it under 10.3: [DCC Fatal Error] OvcRvExpDef.pas(2185): F2084 Internal Error: C15211

rpottsoh commented 5 years ago

I presume a 10.3 compatible version will be available here at some point. I have a 10.3 compatible version available that you are welcome to use in the interim. It is not a fork of Orpheus from TurboPack. It was originally a mirror from https://svn.code.sf.net/p/tporpheus/code/trunk and appears to have been very well maintained over the years. making it 10.3 compatible was not too difficult.

oliverClimbs commented 5 years ago

If you can make the 10.3 compatible version available it would be very much appreciated as Orpheus was removed from the GetIt Manager in C++ Builder 10.3 and I still use numerous components of it in my application.

rpottsoh commented 5 years ago

My apologizes. I presumed anyone interested would venture to my GitHub and find the repo. I didn't want to step on any toes here by posting a link to my repo.

oliverClimbs commented 5 years ago

I am not that familiar with Github, so I didn't think of looking at your repository. Now, I did download Orpheus from there, but I can only find a package for Delphi 10.3, but not for Builder C++ 10.3. Am I missing something here?

rpottsoh commented 5 years ago

Ah.. I don't use Builder. My suggestion would be to start with the latest Builder package and then save as a 10.3 version, change the name of the packages appropriately, then try building the packages. Then address the issues as they are pointed out by the compiler. This is essentially what I did for Delphi. If you need further assistance while using my fork you may want to open an issue there. I can try to help as much as I can, but I don't have Builder installed to work with.

Sent from my android device.

rpottsoh commented 5 years ago

@oschubert regarding:

[DCC Fatal Error] OvcRvExpDef.pas(2185): F2084 Internal Error: C15211

For you reference I just spoke of this specific error here #16. I only bring it up in case you still encounter the error.

oliverClimbs commented 5 years ago

I was able to compile the Orpheus package by just changing the last occurrence as described in #16. I didn't even have to change the first occurrence.

However, when I try to install the package I get a "Entry point not found" error message.

rpottsoh commented 5 years ago

I suggest trying the 103Rio branch of this repo. There have been some updates made for C++ Builder. I am not sure if the changes are complete. But there is no harm in trying.

oliverClimbs commented 5 years ago

Still had to make the same change manually as in #16 for it to compile, but unfortunately I am still getting the same "Entry point not found" error as before.

rpottsoh commented 5 years ago

@jimmckeeth is there anything you can think of for @oschubert to try?

jimmckeeth commented 5 years ago

I just pushed a new update for Rio.

flydev-fr commented 5 years ago

@jimmckeeth I tried to compile it on Delphi Rio 10.3 Pro, it produce the same error [DCC Fatal Error] OvcRvExpDef.pas(2185): F2084 Internal Error: C15211 and it look like the fix isn't commited in the last update.

The change needed in OvcRvExpDef.pas#L2183 :

Result := VarIsNull(TestValue) xor UnaryNot;

to

Result := (TestValue = null) xor UnaryNot;

thanks for the update!

rpottsoh commented 5 years ago

This line: https://github.com/TurboPack/Orpheus/blob/0dcfb600348b42aac37af428e51362415443ec79/source/OvcRvExpDef.pas#L2170 is also an issue.

I never did really figure out why (I would like to know). I know (TestValue = null) xor UnaryNot is satisfactory to the compiler, but I do not know if it has the same desired result as the original statement that that contains VarIsNull. I am not sure if the DUnit tests cover this section of code.

oliverClimbs commented 5 years ago

I was able to install Orpheus using the GetIt manager (despite some error messages during the whole process).