search

TurboVNC / turbovnc

Main TurboVNC repository
https://TurboVNC.org
GNU General Public License v2.0
761 stars 138 forks source link

The remote view is not scaling fully vertically in full screen mode #297

Closed slehrs closed 3 years ago

slehrs commented 3 years ago

The issue started after Windows 10 update on 7/19/2021

dcommander commented 3 years ago

Will investigate. Is this with the native Windows viewer or the Java viewer?

slehrs commented 3 years ago

It’s the native Windows viewer.

From: DRC @.> Sent: Thursday, July 22, 2021 12:20 PM To: TurboVNC/turbovnc @.> Cc: Lehrs, Shachar @.>; Author @.> Subject: Re: [TurboVNC/turbovnc] The remote view is not scaling fully vertically in full screen mode (#297)

CAUTION: This email originated from outside of Zenith Insurance Company. DO NOT CLICK on any links or open any attachments unless you trust the sender, have verified the official email address, and know the content is safe. You can forward the email to @.**@.> for IT to validate the legitimacy.

Will investigate. Is this with the native Windows viewer or the Java viewer?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/TurboVNC/turbovnc/issues/297#issuecomment-885170993, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU6CISDNVNXQNGGTFQD3WN3TZBVNLANCNFSM5A2QDCCQ.

NOTICE: This e-mail, including attachments, contains information that may be confidential, protected by the attorney/client or other privileges, or exempt from disclosure under applicable law. Further, this e-mail may contain information that is proprietary and/or constitutes a trade secret. This e-mail, including attachments, constitutes non-public information intended to be conveyed only to the designated recipient of this communication, please be advised that any disclosure, dissemination, distribution, copying, or other use of this communication or any attached document is strictly prohibited. If you have received this communication in error, please notify the sender immediately by reply e-mail and promptly destroy all electronic and printed copies of this communication and attached documents.

slehrs commented 3 years ago

Any luck with this issue?

From: Lehrs, Shachar Sent: Thursday, July 22, 2021 1:21 PM To: 'TurboVNC/turbovnc' @.***> Subject: RE: [TurboVNC/turbovnc] The remote view is not scaling fully vertically in full screen mode (#297)

It’s the native Windows viewer.

From: DRC @.**@.>> Sent: Thursday, July 22, 2021 12:20 PM To: TurboVNC/turbovnc @.**@.>> Cc: Lehrs, Shachar @.**@.>>; Author @.**@.>> Subject: Re: [TurboVNC/turbovnc] The remote view is not scaling fully vertically in full screen mode (#297)

CAUTION: This email originated from outside of Zenith Insurance Company. DO NOT CLICK on any links or open any attachments unless you trust the sender, have verified the official email address, and know the content is safe. You can forward the email to @.**@.> for IT to validate the legitimacy.

Will investigate. Is this with the native Windows viewer or the Java viewer?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/TurboVNC/turbovnc/issues/297#issuecomment-885170993, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU6CISDNVNXQNGGTFQD3WN3TZBVNLANCNFSM5A2QDCCQ.

NOTICE: This e-mail, including attachments, contains information that may be confidential, protected by the attorney/client or other privileges, or exempt from disclosure under applicable law. Further, this e-mail may contain information that is proprietary and/or constitutes a trade secret. This e-mail, including attachments, constitutes non-public information intended to be conveyed only to the designated recipient of this communication, please be advised that any disclosure, dissemination, distribution, copying, or other use of this communication or any attached document is strictly prohibited. If you have received this communication in error, please notify the sender immediately by reply e-mail and promptly destroy all electronic and printed copies of this communication and attached documents.

dcommander commented 3 years ago

Since it is a regression caused by Windows and will require upgrading my virtual machine, it may take some time before I can look into it.

slehrs commented 3 years ago

Thank you. I appreciate it.

From: DRC @.> Sent: Thursday, July 29, 2021 8:28 PM To: TurboVNC/turbovnc @.> Cc: Lehrs, Shachar @.>; Author @.> Subject: Re: [TurboVNC/turbovnc] The remote view is not scaling fully vertically in full screen mode (#297)

CAUTION: This email originated from outside of Zenith Insurance Company. DO NOT CLICK on any links or open any attachments unless you trust the sender, have verified the official email address, and know the content is safe. You can forward the email to @.**@.> for IT to validate the legitimacy.

Since it is a regression caused by Windows and will require upgrading my virtual machine, it may take some time before I can look into it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/TurboVNC/turbovnc/issues/297#issuecomment-889601342, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU6CISAOA56MI4GFGC3XLXDT2IL45ANCNFSM5A2QDCCQ.

NOTICE: This e-mail, including attachments, contains information that may be confidential, protected by the attorney/client or other privileges, or exempt from disclosure under applicable law. Further, this e-mail may contain information that is proprietary and/or constitutes a trade secret. This e-mail, including attachments, constitutes non-public information intended to be conveyed only to the designated recipient of this communication, please be advised that any disclosure, dissemination, distribution, copying, or other use of this communication or any attached document is strictly prohibited. If you have received this communication in error, please notify the sender immediately by reply e-mail and promptly destroy all electronic and printed copies of this communication and attached documents.

dcommander commented 3 years ago

I upgraded to 21H1 with the latest Windows updates, but I can't reproduce any problems with the scaling feature in the native Windows TurboVNC Viewer. Please specify the resolution of your TurboVNC session as well as the resolution of your client's screen. Also please specify what you mean by "not scaling fully vertically." Note that, whereas the Java TurboVNC Viewer has an "automatic" scaling mode that stretches both the width and height to fill the client's screen, the native Windows TurboVNC Viewer does not have that mode. The Windows TurboVNC Viewer can only scale in such a way that the aspect ratio is maintained, so if your TurboVNC session has a larger aspect ratio than your client's screen, then it is expected that the viewer will not vertically fill the client's screen when in full-screen mode. The solution is to select a TurboVNC session geometry that has the same aspect ratio as the client's screen or to use automatic desktop resizing rather than scaling. If the viewer does not behave as specified above, then it probably is a bug, but I need more information in order to reproduce it.

slehrs commented 3 years ago

I ran TurboVNC session with the same geometry as my screen and it works great! Thank you very much for your help!

From: DRC @.> Sent: Friday, August 27, 2021 2:14 PM To: TurboVNC/turbovnc @.> Cc: Lehrs, Shachar @.>; Author @.> Subject: Re: [TurboVNC/turbovnc] The remote view is not scaling fully vertically in full screen mode (#297)

CAUTION: This email originated from outside of Zenith Insurance Company. DO NOT CLICK on any links or open any attachments unless you trust the sender, have verified the official email address, and know the content is safe. You can forward the email to @.**@.> for IT to validate the legitimacy.

I upgraded to 21H1 with the latest Windows updates, but I can't reproduce any problems with the scaling feature in the native Windows TurboVNC Viewer. Please specify the resolution of your TurboVNC session as well as the resolution of your client's screen. Also please specify what you mean by "not scaling fully vertically." Note that, whereas the Java TurboVNC Viewer has an "automatic" scaling mode that stretches both the width and height to fill the client's screen, the native Windows TurboVNC Viewer does not have that mode. The Windows TurboVNC Viewer can only scale in such a way that the aspect ratio is maintained, so if your TurboVNC session has a larger aspect ratio than your client's screen, then it is expected that the viewer will not vertically fill the client's screen when in full-screen mode. The solution is to select a TurboVNC session geometry that has the same aspect ratio as the client's screen or to use automatic desktop resizing rather than scaling. If the viewer does not behave as specified above, then it probably is a bug, but I need more information in order to reproduce it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/TurboVNC/turbovnc/issues/297#issuecomment-907479594, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU6CISGMFRL7LVRLCYWX2LTT675ZHANCNFSM5A2QDCCQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

NOTICE: This e-mail, including attachments, contains information that may be confidential, protected by the attorney/client or other privileges, or exempt from disclosure under applicable law. Further, this e-mail may contain information that is proprietary and/or constitutes a trade secret. This e-mail, including attachments, constitutes non-public information intended to be conveyed only to the designated recipient of this communication, please be advised that any disclosure, dissemination, distribution, copying, or other use of this communication or any attached document is strictly prohibited. If you have received this communication in error, please notify the sender immediately by reply e-mail and promptly destroy all electronic and printed copies of this communication and attached documents.

dcommander commented 3 years ago

Does it also work properly if you launch a TurboVNC session with a different geometry but the same aspect ratio as your screen? If so, then I suspect that this issue was a misunderstanding rather than a bug.

slehrs commented 3 years ago

Yes, there’s no bug. I just ran it with a different aspect ratio geometry. I didn’t check but I assume it should work fine when running with same aspect ratio geometry.

From: DRC @.> Sent: Monday, August 30, 2021 10:28 AM To: TurboVNC/turbovnc @.> Cc: Lehrs, Shachar @.>; Author @.> Subject: Re: [TurboVNC/turbovnc] The remote view is not scaling fully vertically in full screen mode (#297)

CAUTION: This email originated from outside of Zenith Insurance Company. DO NOT CLICK on any links or open any attachments unless you trust the sender, have verified the official email address, and know the content is safe. You can forward the email to @.**@.> for IT to validate the legitimacy.

Does it also work properly if you run a TurboVNC session with a different geometry but the same aspect ratio as your screen? If so, then I suspect that this issue was a misunderstanding rather than a bug.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/TurboVNC/turbovnc/issues/297#issuecomment-908535186, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU6CISHWWPO7WGWK4E3EN5DT7O5SHANCNFSM5A2QDCCQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

NOTICE: This e-mail, including attachments, contains information that may be confidential, protected by the attorney/client or other privileges, or exempt from disclosure under applicable law. Further, this e-mail may contain information that is proprietary and/or constitutes a trade secret. This e-mail, including attachments, constitutes non-public information intended to be conveyed only to the designated recipient of this communication, please be advised that any disclosure, dissemination, distribution, copying, or other use of this communication or any attached document is strictly prohibited. If you have received this communication in error, please notify the sender immediately by reply e-mail and promptly destroy all electronic and printed copies of this communication and attached documents.