search

TurboWarp / desktop

A better offline editor for Scratch 3.
https://desktop.turbowarp.org/
GNU General Public License v3.0
372 stars 88 forks source link

MIME type fixes suggestion #106

Open Botspot opened 3 years ago

Botspot commented 3 years ago

TurboWarp has been added to the Pi-Apps Raspberry Pi app store.

As I was creating the app, I realized there was the potential for a major improvement: a MIME type.
On the default Raspberry Pi OS, there is no mime type for .sb3 files. If you double-click on a sb3 file, it will literally open the file as if it was a zip file.

To improve the user-experience, I added a mime type file. Pi-Apps users will enjoy the ability to double-click on their .sb3 files and see them open directly in TurboWarp.
mime type before and after
Would you guys be interested in making the same change upstream for everybody?

Feel free to review my installation script and see how I did it. In addition to the mime type, I also tweaked the menu launcher to sit in the Programming category. (Just like the real Scratch 3 Desktop)
I'll do my best to answer any questions you have.

GarboMuffin commented 3 years ago

Quick question about the Pi-Apps Raspberry Pi app store: How do you handle updates? TurboWarp Desktop has a builtin autoupdater that shows an alert on startup when there's an update available with a link to https://desktop.turbowarp.org/, do you want a way to disable that?

Botspot commented 3 years ago

Quick question about the Pi-Apps Raspberry Pi app store: How do you handle updates? TurboWarp Desktop has a builtin autoupdater that shows an alert on startup when there's an update available with a link to https://desktop.turbowarp.org/, do you want a way to disable that?

Great question.
The Pi-Apps update process is really quite simple: if AppX is installed, and AppX's install script has been modified on the github repo, then during an update Pi-Apps will:

  1. Uninstall AppX. (it will execute AppX's uninstall script)
  2. Update AppX's installation scripts.
  3. Install AppX back.

So, the next time TurboWarp receives a new deb release, one of us Pi-Apps developers will modify the download URL within the install script. That modification will trigger an update to all Pi-Apps users. Those who have TurboWarp installed, will have TurboWarp reinstalled for them.

I wouldn't bother disabling your update checker.

GarboMuffin commented 3 years ago

master now sets .sb3's mime type to application/x.scratch.sb3 (used by Scratch: https://github.com/LLK/scratch-vm/blob/d01f04bd3e1ad2596624dff24d6a30990a58a198/src/virtual-machine.js#L391) and it seems like the app will now automatically make itself the sb3 handler

The icon seems to be hardcoded as a generic x-office-document in electron-builder, which isn't ideal