search

TurboWarp / extensions

User-contributed unsandboxed extension gallery for TurboWarp
https://extensions.turbowarp.org/
MIT License
107 stars 219 forks source link

New extension: Simple 3D #1417

Closed Xeltalliv closed 1 month ago

Xeltalliv commented 2 months ago

Extension for making simple-looking GPU accelerated 3D easily. Originally announced here, it's finally done. Convenience links:

Image (slightly outdated): image

Some things that still need to be clarified before it is merged:

LilyMakesThings commented 2 months ago

now that is a chonky boi

GarboMuffin commented 2 months ago

@Xeltalliv send me a discord dm when you think this is properly done (it is too large to thoroughly review and I get too many github notifications)

MrFluffyBerry commented 2 months ago

This is cool!!!!... How to draw a cube...😭💀

Xeltalliv commented 2 months ago

If anyone needs more sample projects, they can be found here https://github.com/Xeltalliv/extensions/tree/simple3d-dev/samples/Xeltalliv

LilyMakesThings commented 2 months ago

let me know when you're actually done with this

Xeltalliv commented 2 months ago

let me know when you're actually done with this

I think it's done. So far, I don't have any more commits planned, but if I find more bugs while using it, I will still try to fix them.

Xeltalliv commented 1 month ago

I will not be running it through prettier myself, because for the reasons stated in original post, it is easier to review it with it's current formatting.

LilyMakesThings commented 1 month ago

I will not be running it through prettier myself, because for the reasons stated in original post, it is easier to review it with it's current formatting.

That's totally fine, prettier is unrelated to the reason this isn't being merged yet (mostly outside reasons)

Xeltalliv commented 1 month ago

For licensing reasons I switched image to another font. I'm not sure about the license of this new DejaVu Sans font either, but I picked it because it was already used in Sensing+ image.

The image was rendered using the extension itself using this project, then saturated by 25 units (range -127 to 127) in GIMP.

veggiecan0419 commented 1 month ago

If anyone needs more sample projects, they can be found here https://github.com/Xeltalliv/extensions/tree/simple3d-dev/samples/Xeltalliv

@Xeltalliv They try to load the extension from the localhost, which doesn't work (unless they have your repo cloned). Could please you make them again, but instead load the extension from file?

Xeltalliv commented 1 month ago

Could please you make them again, but instead load the extension from file?

@veggiecan0419 I thought about it when publishing them, but decided to do that intentionally, to force everyone to use the latest version of the extension, by manually pre-loading it from text before opening the project.

Drago-Cuven commented 1 month ago

As a result, some people can't use the extension at all. Like me. I'm on chromebook and can't use localhost. (I can't use Linux bc of lack of memory.)

On Wed, May 8, 2024, 4:56 PM Xeltalliv @.***> wrote:

Could please you make them again, but instead load the extension from file?

@veggiecan0419 https://github.com/veggiecan0419 I could, I thought about it when publishing them, but decided to do that intentionally, to force everyone to use the latest version of the extension, by manually pre-loading it from text before opening the project.

— Reply to this email directly, view it on GitHub https://github.com/TurboWarp/extensions/pull/1417#issuecomment-2101565425, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANYWUKP5MIYLPDY4O3ERMOLZBKNQNAVCNFSM6AAAAABGROXKW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGU3DKNBSGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Xeltalliv commented 1 month ago

@Drago-Cuven As I said in my previous reply, you can simply manually copy-paste extension code, load it from text into the empty TurboWarp editor, and after it's been loaded, open any project that requires it. If required extension is already loaded, TurboWarp will not attempt to load it again, so it will load fine even without localhost.

GarboMuffin commented 1 month ago

@Xeltalliv So here's the deal, this is too big for me to actually properly review aside from making sure you didn't sneak any malware into it. I pushed commits to fix all the nitpicks I have. If you think it is done, let me know and I will merge within 24 hours

You can use // prettier-ignore when you think that you can make it look better than prettier does. I put that in places that work with matrices etc. where I agree, prettier does ruin it, but most of the other changes it makes are pretty reasonable.

Xeltalliv commented 1 month ago

@GarboMuffin Thanks! By now I think it's definitely done.

https://github.com/TurboWarp/extensions/pull/1417/commits/df8755723ad99928bf6881b316fb005f55f6e788 fixed the mistake introduced in https://github.com/TurboWarp/extensions/pull/1417/commits/cb34724c1f41c93013f12a58e0d55f72c1172964