search

TurboWarp / extensions

User-contributed unsandboxed extension gallery for TurboWarp
https://extensions.turbowarp.org/
MIT License
107 stars 217 forks source link

Translate mobilekeyboard menu defaultValue #1498

Closed veggiecan0419 closed 4 weeks ago

veggiecan0419 commented 1 month ago

Maybe this should be done for some other extensions too?

veggiecan0419 commented 4 weeks ago

@GarboMuffin

GarboMuffin commented 4 weeks ago

You shouldn't translate menu values, just text

GarboMuffin commented 4 weeks ago

they are already translated so you dont need to do anything else

https://github.com/TurboWarp/extensions/blob/084034a6989e6baced5ba2811e2d68148d76a068/extensions/veggiecan/mobilekeyboard.js#L146-L169

if anything the defaultValue should be removed