TurboWarp / extensions

User-contributed unsandboxed extension gallery for TurboWarp
https://extensions.turbowarp.org/
MIT License
107 stars 217 forks source link

Lily/Video: Add new 'frame of video (my video) at (0) seconds' block #1536

Open LSPECTRONIZTAR opened 2 weeks ago

LSPECTRONIZTAR commented 2 weeks ago

New block for the Lily/Video extension that adds a block 'frame of video (my video) at (0) seconds' where it returns the data:URI of the frame of the video at a given time in the video. Can be useful for trying to draw videos in 3D space (using Pen+) making video editing projects similar to CapCut or PowerDirector.

Let me just make it clear that @SharkPool-SP made this extension, not me (the only JavaScript I know is JSON tbh lol). He gave me permission: https://github.com/TurboWarp/extensions/pull/1536#issuecomment-2161864709

This is my first PR i need this so bad

AshimeeAlt commented 2 weeks ago

maybe move the comment saying sp made the block above the function or the block json

LSPECTRONIZTAR commented 2 weeks ago

maybe move the comment saying sp made the block above the function or the block json

Will that fix the checks? I know this ain't getting merged without all successful checks

LSPECTRONIZTAR commented 2 weeks ago

maybe move the comment saying sp made the block above the function or the block json

IMG_0089 like this?

AshimeeAlt commented 2 weeks ago

maybe move the comment saying sp made the block above the function or the block json

IMG_0089 like this?

yes but its not going to fix the prettier check, it will be fixed when merged

LSPECTRONIZTAR commented 2 weeks ago

maybe move the comment saying sp made the block above the function or the block json

IMG_0089 like this?

yes but its not going to fix the prettier check, it will be fixed when merged

I don't think it's getting merged unless all checks are successful but ok

SharkPool-SP commented 2 weeks ago

Just in case Garbo sees this, I did give permission for him to use my modified code and make the pr.