search

TurboWarp / extensions

User-contributed unsandboxed extension gallery for TurboWarp
https://extensions.turbowarp.org/
MIT License
116 stars 232 forks source link

Timeutils #1571

Closed unknown07724 closed 3 months ago

LilyMakesThings commented 3 months ago

Creating TurboWarp extensions requires a fundamental knowledge of JavaScript. Once you have learned JavaScript and are confident with the TurboWarp extension API, that's when submitting your ideas is recommended.

GarboMuffin commented 3 months ago

i think there's better ways to express that but yes this will not be merged on the basis that the single block it adds is not useful

GarboMuffin commented 3 months ago

The syntax error is because class timeutils { does not have a matching }. The } at the end corresponds to wait(args) {, so the class timeutils { is never closed, so it still thinks you're defining a class

(but again, fixing the syntax error does not get this into a mergeable state. we are already very backlogged on extension review and can't provide help with javascript syntax, sorry)

unknown07724 commented 3 months ago

I am going to still work on timeutils and make another pull request as soon as I learn how to convert milliseconds to seconds via javascript

AshimeeAlt commented 3 months ago

I am going to assume you read what GarboMuffin and Lily said, but right now this won't be merged due to a few issues mainly being the know-how of JavaScript and the block not being necessary let alone in its own extension

​we are already very backlogged on extension review

​but yes this will not be merged on the basis that the single block it adds is not useful

Please don't make another pull request that's just this but fixed, It will save everyone a lot of time.

Get to learn the extension format and JavaScript and maybe you will make some cool stuff.

(I do not know if I am being too harsh so if so, I am sorry)

From: unknown07724 @.> Sent: Wednesday, June 26, 2024 10:45 PM To: TurboWarp/extensions @.> Cc: Subscribed @.***> Subject: Re: [TurboWarp/extensions] Timeutils (PR #1571)

I am going to still work on timeutils and make another pull request as soon as I learn how to convert milliseconds to seconds via javascript

— Reply to this email directly, view it on GitHubhttps://github.com/TurboWarp/extensions/pull/1571#issuecomment-2193031689, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGM6GVP5BSHGMFSQVHCVM7LZJN4EVAVCNFSM6AAAAABJ6JWDLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTGAZTCNRYHE. You are receiving this because you are subscribed to this thread.Message ID: @.***>

unknown07724 commented 3 months ago

it will have new blocks

AshimeeAlt commented 3 months ago

There is already a time extension, try to expand on that instead, but first please learn JavaScript if you have not 🙏

From: unknown07724 @.> Sent: Wednesday, June 26, 2024 11:02 PM To: TurboWarp/extensions @.> Cc: AshimeeAlt @.>; Comment @.> Subject: Re: [TurboWarp/extensions] Timeutils (PR #1571)

it will have new blocks

— Reply to this email directly, view it on GitHubhttps://github.com/TurboWarp/extensions/pull/1571#issuecomment-2193117597, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGM6GVNZ32LK2PNZ4XARBHDZJN6CRAVCNFSM6AAAAABJ6JWDLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTGEYTONJZG4. You are receiving this because you commented.Message ID: @.***>

unknown07724 commented 3 months ago

it doesn't allow you to wait milliseconds or minutes or convert milliseconds to seconds

AshimeeAlt commented 3 months ago

more controls, controls+, and many other older and in pr extensions have wait frames and ms, and also its still a unnecessary block + I said expand :skull:

From: unknown07724 @.> Sent: Wednesday, June 26, 2024 11:05 PM To: TurboWarp/extensions @.> Cc: AshimeeAlt @.>; Comment @.> Subject: Re: [TurboWarp/extensions] Timeutils (PR #1571)

it doesn't allow you to wait milliseconds or minutes or convert milliseconds to seconds

— Reply to this email directly, view it on GitHubhttps://github.com/TurboWarp/extensions/pull/1571#issuecomment-2193136670, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGM6GVIC6Q57O4QFDPTGOCDZJN6PBAVCNFSM6AAAAABJ6JWDLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTGEZTMNRXGA. You are receiving this because you commented.Message ID: @.***>

unknown07724 commented 3 months ago

3 blocks, 1.0 is done(I used chatGPT and fixed any errors it made)

AshimeeAlt commented 3 months ago

AI made extensions are forbidden

From: unknown07724 @.> Sent: Wednesday, June 26, 2024 11:14 PM To: TurboWarp/extensions @.> Cc: AshimeeAlt @.>; Comment @.> Subject: Re: [TurboWarp/extensions] Timeutils (PR #1571)

3 blocks, 1.0 is done(I used chatGPT and fixed any errors it made)

— Reply to this email directly, view it on GitHubhttps://github.com/TurboWarp/extensions/pull/1571#issuecomment-2193189478, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGM6GVNWC3Y4X65LUKSAZT3ZJN7RDAVCNFSM6AAAAABJ6JWDLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTGE4DSNBXHA. You are receiving this because you commented.Message ID: @.***>

unknown07724 commented 3 months ago

the contributing.md file doesn't say so

unknown07724 commented 3 months ago

also I eventually gave up trying to tell the AI to do what I asked so I opened VS code and coded

unknown07724 commented 3 months ago

plus I emailed garbo muffin and asked how to add extension and he eventually said to ask chatgpt to fix it for me

unknown07724 commented 3 months ago

just in case that I am stupid(probably) I will remake timeutils

AshimeeAlt commented 3 months ago

That does not disregard the fact that ChatGPT does not know how to properly write extensions. (Same with this, and it seems the line was removed but the fact still remains https://github.com/TurboWarp/extensions/commit/b7d740b95c61818be43d20bdb079577d3bc413b4)

From: unknown07724 @.> Sent: Wednesday, June 26, 2024 11:39 PM To: TurboWarp/extensions @.> Cc: AshimeeAlt @.>; Comment @.> Subject: Re: [TurboWarp/extensions] Timeutils (PR #1571)

plus I emailed garbo muffin and asked how to add extension and he eventually said to ask chatgpt to fix it for me

— Reply to this email directly, view it on GitHubhttps://github.com/TurboWarp/extensions/pull/1571#issuecomment-2193357378, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGM6GVOATUP4Z2YR6FP3IEDZJOCPRAVCNFSM6AAAAABJ6JWDLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTGM2TOMZXHA. You are receiving this because you commented.Message ID: @.***>

unknown07724 commented 3 months ago

That must be outdated as it added a label and 2 new blocks the problem came with color1 which isn't required

unknown07724 commented 3 months ago

when it was on 3.5

unknown07724 commented 3 months ago

I am making an extension to prove that chatgpt can make a extension

AshimeeAlt commented 3 months ago

,,, im not going to continue with you cause ChatGPT cannot make an extension correctly you are wasting your time.

From: unknown07724 @.> Sent: Thursday, June 27, 2024 12:15 AM To: TurboWarp/extensions @.> Cc: AshimeeAlt @.>; Comment @.> Subject: Re: [TurboWarp/extensions] Timeutils (PR #1571)

I am making an extension to prove that chatgpt can make a extension

— Reply to this email directly, view it on GitHubhttps://github.com/TurboWarp/extensions/pull/1571#issuecomment-2193636852, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGM6GVJCFKFPOSHWVGLH3DDZJOGXXAVCNFSM6AAAAABJ6JWDLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTGYZTMOBVGI. You are receiving this because you commented.Message ID: @.***>

AshimeeAlt commented 3 months ago

I hope you have a great day day or night 👍

From: unknown07724 @.> Sent: Thursday, June 27, 2024 12:15 AM To: TurboWarp/extensions @.> Cc: AshimeeAlt @.>; Comment @.> Subject: Re: [TurboWarp/extensions] Timeutils (PR #1571)

I am making an extension to prove that chatgpt can make a extension

— Reply to this email directly, view it on GitHubhttps://github.com/TurboWarp/extensions/pull/1571#issuecomment-2193636852, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BGM6GVJCFKFPOSHWVGLH3DDZJOGXXAVCNFSM6AAAAABJ6JWDLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTGYZTMOBVGI. You are receiving this because you commented.Message ID: @.***>

unknown07724 commented 3 months ago

yes it can

unknown07724 commented 3 months ago

turbowarp reads it and doesn't error that is what correctly means

GarboMuffin commented 3 months ago

I told you to use chatgpt to help you fix syntax errors, nothing more. I do not want to be your personal JavaScript syntax checker.

GarboMuffin commented 3 months ago

AI can be a valuable helper and learning tool but submitting fully AI generated garbage here will not be merged (you will also be blocked) and will not help you learn JavaScript.