search

TurboWarp / extensions

User-contributed unsandboxed extension gallery for TurboWarp
https://extensions.turbowarp.org/
MIT License
119 stars 237 forks source link

Extension Gallery thumbnail submissions again #1607

Open xTvii opened 4 months ago

xTvii commented 4 months ago

1079 but like the icons are miles better . and i also provide reasoning towards my changes ( btw they get cropped automatically + im kinda lazy ..... and most cropping tools online i can find are making the whole file break so smh )

' S-Grab ' im just resubmitting it because it didnt get noticed and i think s grab really needs a visual upgrade :? S-Grab

' Simple 3D ' it had text and im removing the text so translators dont have to deal with svg files Simple 3D

' Close Confirm ' we hate text but we LOOVEEE consistency !!!!! all assets in the old ( current ) image are either squares or strings of text :( Close Confirm

' Vibrate ' ngl something about the original design is just .. off . also the outlines were opaque Vibrate

' Time ' & ' Consoles ' same as simple 3d . i removed the text and added outlines for the main icons :O Consoles(1) Time(1)

' Font Manager ' same as simple 3d &&& i changed some thing with the icon B) Font Manager

' Numerical Encoding ' i tried to change it in 1079 but it turned out absolutely abysmal . so i redid the redo . ngl it looks much cleaner Numerical Encoding2

' HTTP ' i redid it .... woah !!! changed backround to something nicer & fixed the icon HTTP

' WebSocket ' holy heck !!! what ! ? ! ? basically just http changes except i did some cool stuff see for yourself idk Websocket

thats all my changes that ive made so farr & this was all made in the turbowarp editor . cool emoji w sunglasses . anyways im gonna tag you in this garbo youre not gonna stop me I WANNA SEE YOU TRY MWAWAHWAHWHAHH I WANNA SEE Y

xTvii commented 4 months ago

btw critisissisimemgmgm appreciated !

veggiecan0419 commented 4 months ago

@xTvii What was the problem with Simple 3d? Personally, I think it looked good how it was before 🤷‍♂️?

xTvii commented 4 months ago

it has text , which garbo said was redundant & hard to translate in #1518

Xeltalliv commented 4 months ago

Sorry, but I'm really not a fan a your new Simple3D image, and view it as a downgrade.

Firstly, the new image is less clear at a glance. The old one has a grid with perspective and letters 3D which makes it clear it's something related to 3D at a glance, even if you don't know what Simple means and quickly scrolling through the list of extensions only looking at thumbnails. Your new image just looks like a confusing shape, and most wouldn't realize it represents 3 axis of 3D from the image alone.

so translators dont have to deal with svg files

The original image is PNG genereated using extension itself. Changing text in it is easy. Generating higher resolution versions is also easy. The project can be found starting from opening extension in turbowarp, pressing "Open extra resources" > "Demos" > "Extension image".

Another thing is the theming of documentation site (https://xeltalliv.github.io/simple3d-extension/) is entirely based around the white-cyan grid from the currect thumbnail.

LilyMakesThings commented 4 months ago

@Xeltalliv text in extension images is discouraged anyway because it is superfluous to the very helpful extension title and description; it's an unnecessary detail that cannot be translated and looks out of place.

David-Orangemoon commented 4 months ago

@Xeltalliv text in extension images is discouraged anyway because it is superfluous to the very helpful extension title and description; it's an unnecessary detail that cannot be translated and looks out of place.

But it would seem rather odd to remove it if it is core to the extension's identity right? As he said the thumbnail is made with the extension.

namelessisbackbutnottodobadthingsiswear commented 4 months ago

@Xeltalliv text in extension images is discouraged anyway because it is superfluous to the very helpful extension title and description; it's an unnecessary detail that cannot be translated and looks out of place.

But it would seem rather odd to remove it if it is core to the extension's identity right? As he said the thumbnail is made with the extension.

Perhaps simplify the text in the title to "3D?" "Simple 3D" would have to be translated since it's English but most languages seem to use the phrase "3D" to indicate the third dimension

namelessisbackbutnottodobadthingsiswear commented 4 months ago

btw critisissisimemgmgm appreciated !

I like the new images (especially close confirm and s-grab). only one I don't really like is numerical encoding, I could be biased since I made the last one but the one you made doesn't really have anything to do with numerical encoding and (for lack of a better adjective) gives off a "so-retro" vibe

SharkPool-SP commented 4 months ago

I dont like Font manager. Also some of these were already done, just @GarboMuffin hasn't implemented them yet. If he reads this, don't change the font manager icon. I can do it myself as its my extension

veggiecan0419 commented 4 months ago

I dont like Font manager. Also some of these were already done, just @GarboMuffin hasn't implemented them yet. If he reads this, don't change the font manager icon. I can do it myself as its my extension

@SharkPool-SP Yes, but it is still absolutely up to @GarboMuffin. Just because its your extension doesn't mean it can't be changed without your permission. This is Garbo's repository, and you decided to contribute. Not saying I prefer the new one or the older one, but I absolutely disagree with the

I can do it myself as its my extension

part. If you want full control over your code, don't contribute to other's (open source) projects.

LilyMakesThings commented 4 months ago

I can do it myself as its my extension

part. If you want full control over your code, don't contribute to other's (open source) projects.

I don't see what being open source has anything to do with this? He has just as much of a right as anyone else to be critical over the thumbnails of any extension, else this issue post wouldn't even exist. He volunteered to do it himself and he is the most qualified to do it, given that it is his extension. Your statement is completely irrelevant.

veggiecan0419 commented 4 months ago

I can do it myself as its my extension

part. If you want full control over your code, don't contribute to other's (open source) projects.

I don't see what being open source has anything to do with this? He has just as much of a right as anyone else to be critical over the thumbnails of any extension, else this issue post wouldn't even exist. He volunteered to do it himself and he is the most qualified to do it, given that it is his extension. Your statement is completely irrelevant.

@LilyMakesThings Yes, But how he said it is as if he is in charge of who can change the image when hes not. Why i said open source is because he knows that this repo is open to contributions by anyone, and that means there might be a change to something he made, which he might not like.

veggiecan0419 commented 4 months ago

@LilyMakesThings, I don't want to start an argument here, But I didn't say SharkPool wasn't the best person to do it, nor did I say he can't do it. But I dont think its acceptable for him to basically say: "Garbo, don't use Xtvii's image. I can do it better, and its my extension". Garbo can decide if he wants to use Xtvii's one, and it doesn't nessecarily matter who's extension it is. Sure Garbo considers the extension creator, but that doesn't mean that he can't change it to whatever he likes.

SharkPool-SP commented 4 months ago

@LilyMakesThings, I don't want to start an argument here, But I didn't say SharkPool wasn't the best person to do it, nor did I say he can't do it. But I dont think its acceptable for him to basically say: "Garbo, don't use Xtvii's image. I can do it better, and its my extension". Garbo can decide if he wants to use Xtvii's one, and it doesn't nessecarily matter who's extension it is. Sure Garbo considers the extension creator, but that doesn't mean that he can't change it to whatever he likes.

What's stopping Garbo from using this and then 3 days later another image. Seems like a waste of everyone's time

GarboMuffin commented 4 months ago

hi, will look at them when able, im just going to disable comments here since it seems unlikely for anything productive to result from more conversation

GarboMuffin commented 4 months ago

i will unlock this but please leave discussion to the images themselves and not commentary about who should be the person to make an image for an extension, which is unproductive. if you don't like it, explain what's actually wrong with the new image or make a better one

xTvii commented 4 months ago

I tried to make them good but i've clearly done something wrong to stir up all this tacky conversation ... I'll try even better if I decide to do it again again !!

xTvii commented 4 months ago

btw sorry if my simple3d sucked , its tradition to get one completely screwed up every time i try !!

CubesterYT commented 4 months ago

@xTvii, no, don't worry; you did nothing wrong. Just another day in TurboWarp 🙄

veggiecan0419 commented 4 months ago

@xTvii, no, don't worry; you did nothing wrong. Just another day in TurboWarp 🙄

True say...

unknown07724 commented 2 months ago

@xTvii if you want to you could create a new banner for an extension in the works called positron, it has a banner but it looks like garbage, it doesn't even fit the thumbnail, keep the circle with plus in it as a positron has a electrical charge of +1 and put it in the center, I will soon put the source code in it's issue, not a pull request because I don't know how those work

unknown07724 commented 2 months ago

1663 is positron's issue

unknown07724 commented 2 months ago

btw sorry if my simple3d sucked , its tradition to get one completely screwed up every time i try !!

my extension's banner is worse than yours