I bring a gift. 🎁 - Githubissues

aetinx commented 4 years ago

If you need anything else (e.g. svg files, more designs), just ask me. My Discord is Speedblocks#0678. I used the right colours and the font is DM Sans.

Synieq OS and Ryfelta Synieq OS and Ryfelta (1)

retronbv commented 4 years ago

YASSSSSSS

retronbv commented 4 years ago

@GarboMuffin Plz use these

retronbv commented 4 years ago

@sargent-coding but did you make versions for the new dark mode?

aetinx commented 4 years ago

@sargent-coding but did you make versions for the new dark mode?

I will. :+1:

retronbv commented 4 years ago

Noice

aetinx commented 4 years ago

Synieq OS and Ryfelta (5) Synieq OS and Ryfelta (6)

retronbv commented 4 years ago

Yasssssss

GarboMuffin commented 4 years ago

Honest feedback:

TurboWarp wants to look and feel like Scratch 3, so I'm not fond of the changes to the menu bar
I'm not fond of making everything lowercase
I don't like making everything red
I'm not sure what the rectangles to the side of the project player are supposed to be. Ad spots? We don't have ads.
Making the homepage of TurboWarp into an actual landing page is a good idea, but I'm not super fond of how it's done here. It's a bit strange to display two control bars on the same page.
Missing links to source code, privacy policy
I'm not going to be adding external fonts
Moving the initial project ID input to a more visible spot is a good idea
I don't see a spot for credits or description, which is something that a redesign needs to have

aetinx commented 3 years ago

Honest feedback:

TurboWarp wants to look and feel like Scratch 3, so I'm not fond of the changes to the menu bar

I'm not fond of making everything lowercase

I don't like making everything red

I'm not sure what the rectangles to the side of the project player are supposed to be. Ad spots? We don't have ads.

Making the homepage of TurboWarp into an actual landing page is a good idea, but I'm not super fond of how it's done here. It's a bit strange to display two control bars on the same page.

Missing links to source code, privacy policy

I'm not going to be adding external fonts

Moving the initial project ID input to a more visible spot is a good idea

I don't see a spot for credits or description, which is something that a redesign needs to have

Okay. Do you wanna just use the logo then?

GarboMuffin commented 3 years ago

I'm not sure how well that icon would look in the extremely cramped space that browsers give websites for icons.

The most likely thing to happen regarding a favicon at this point is me putting a white turbo mode icon in a red circle.

aetinx commented 3 years ago

Wouldn't you put it on the left side of the languages icon? There's lots of room on the navbar.

proton0va commented 3 years ago

i like that design.

Secret-chest commented 3 years ago

I'm not going to be adding external fonts

Why?

GarboMuffin commented 3 years ago

Custom fonts are a waste of CPU cycles and network traffic, and using eg. Google Fonts makes me very concerned about privacy. The system already has fonts, why can't we use those? They'll look nice and native too

GarboMuffin commented 3 years ago

scratch-gui is a massive library that I've been trying to shrink and optimize startup performance of. Adding fonts (increasing page load time, amount of network traffic, layout shift) would invalidate all of that, and also make us look weird compared to Scratch. There is no discernible benefit to using custom fonts, but lots of downsides.

Secret-chest commented 3 years ago

Custom fonts are a waste of CPU cycles and network traffic, and using eg. Google Fonts makes me very concerned about privacy. The system already has fonts, why can't we use those? They'll look nice and native too

@GarboMuffin Then use system-ui, so I don't see Liberation Sans! I use Linux

GarboMuffin commented 3 years ago

Scratch uses

"Helvetica Neue", Helvetica, Arial, sans-serif

so that's what we use too. If there's a problem, ask Scratch to change it or fix your system font configuration. Point is that I'm not going to fetch more custom fonts just to make the interface look a bit different.

cobaltt7 commented 3 years ago

It's already against the Code Of Conduct.

From: Time Dragon @.> Sent: Sunday, May 30, 2021 9:40:32 AM To: TurboWarp/scratch-gui @.> Cc: Subscribed @.***> Subject: Re: [TurboWarp/scratch-gui] I bring a gift. 🎁 (#22)

@GarboMuffinhttps://github.com/GarboMuffin sorry to ping you (and go off-topic) but add a no swearing thing to the readme

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/TurboWarp/scratch-gui/issues/22#issuecomment-851027527, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOT5DERASLSMSZ5SE7GGX33TQJTABANCNFSM4SI6SFJQ.

Secret-chest commented 3 years ago

Scratch uses

"Helvetica Neue", Helvetica, Arial, sans-serif

so that's what we use too. If there's a problem, ask Scratch to change it or fix your system font configuration. Point is that I'm not going to fetch more custom fonts just to make the interface look a bit different.

@GarboMuffin Just use system-ui! It will look more native

GarboMuffin commented 3 years ago

but Scratch doesn't use system-ui, so it will end up looking inconsistent and strange to our users

GarboMuffin commented 3 years ago

There will probably be an addon soon that lets you use custom fonts, so you could set it to system-ui or something else.

We're pretty offtopic now, if you have anything else to say about fonts then open a new issue.

TurboWarp / scratch-gui

I bring a gift. 🎁 #22

If you need anything else (e.g. svg files, more designs), just ask me. My Discord is Speedblocks#0678. I used the right colours and the font is DM Sans.