TurboWarp / scratch-vm

Scratch VM with a JIT compiler and more features
https://turbowarp.org/
Mozilla Public License 2.0
75 stars 72 forks source link

Add acceptReporters to more inputs. #191

Closed LilyMakesThings closed 8 months ago

LilyMakesThings commented 8 months ago

Proposed Changes

Add an acceptReporters option for argument placeholders.

Reason for Changes

TurboWarp's argument types currently always allow for reporters to be accepted. Other features, like event-based hats, are exclusively limited to discriminating by fields.

Some features do require the input/customisation of a user, but without it changing in real-time with, for example a variable reporter.

Allowing for fields to be directly inside of blocks would also open up more customisation for extension developers.

It also feels more intuitive for acceptReporters to apply to every type of input, not just menus; we can have menus be only sometimes able to accept reporters (kind of like the broadcast menu/field).

Test Coverage

Haven't touched actual tests.

Known Problems

LilyMakesThings commented 8 months ago

I'm not going to work on the other changes I mentioned. If this is merged I'll submit another PR, and if it isn't I'll add onto it.