TurckBDMs-Main / IOLinkAOIs

This project will be used to take the existing Turck IO-Link AOIs to the next level to include more diagnostics and the ability to integrate Index Data.
2 stars 5 forks source link

If port is set to zero it creates a major fault on the PLC #51

Closed jose-sanchez-tcan closed 7 months ago

jose-sanchez-tcan commented 7 months ago

I was testing using a "port" variable instead of a fix value to accelerate testing time., since it's initialized at 0 it generates a major fault on the PLC. It's not unfeasible to think a customer would enter a 0 there, specially when confusing C0 with port 1.

For now I added an LES on the Generic Process Data AOI to set the Port value (Port_Less_One) to 0 if it gets a value less than 0.

I tested setting port to 0 on the universal device info and also got a major fault.

jose-sanchez-tcan commented 7 months ago

Generic process AOI was corrected.

nickcluteturck commented 7 months ago

All other device AOIs and generic have been corrected.