Turfjs / turf-intersect

find the intersection of features
30 stars 9 forks source link

Kill jsts #10

Closed tcql closed 7 years ago

tcql commented 9 years ago

This PR uses the greiner-hormann algorithm that I've been working on implementing. It's considerably faster than JSTS, and removes our dependency on JSTS, aside from turf-buffer.

There are likely some quirks / edge case failures here, but we'll deal with those as they come up. Here's some known differences in the behavior:

tcql commented 9 years ago

oh woops, messed up some of the comments / docblock. I'll fix it up.

tcql commented 9 years ago

Note: I changed the tests and pulled in dev-dependency geojson-equality because point orders in results changed

anandthakker commented 9 years ago

@tchannel @morganherlocker Anything I could do to help this along?

morganherlocker commented 9 years ago

@anandthakker the one remaining JSTS dependency is for polygon buffering.

anandthakker commented 9 years ago

@morganherlocker Oof

tcql commented 9 years ago

@anandthakker I've also noticed a few bugs in the Greiner-Hormann implementation, which I've been chipping away at (tchannel/greiner-hormann#15, tchannel/greiner-hormann#14)

I also want to clean up, RE: tchannel/greiner-hormann#11

DrColossos commented 8 years ago

is there any progress on this? we would love to have this inside turf-intersect since JSTS bloats our build immensely.

DenisCarriere commented 7 years ago

@tcql great work on these commits 👍 I want to merge this, however could you send a PR to the main TurfJS repo instead.

https://github.com/Turfjs/turf/tree/master/packages/turf-intersect

If not, let me know and I can help out with merging it into main Turf repo.

tcql commented 7 years ago

@DenisCarriere the greiner-hormann has some pretty serious bugs that I found after putting this PR together. The package also hasn't been under development recently. I'd still love to circle back sometime and improve it, but for now this dependency murderquest is dead.

DenisCarriere commented 7 years ago

@tcql that's a shame... I'm very PRO removing jsts, however it's not going to be an easy task.