search

TuringLang / AbstractMCMC.jl

Abstract types and interfaces for Markov chain Monte Carlo methods
https://turinglang.org/AbstractMCMC.jl
MIT License
78 stars 18 forks source link

Replace `GLOBAL_RNG` with `default_rng()` #104

Closed devmotion closed 2 years ago

devmotion commented 2 years ago

In Julia >= 1.3, actually Random.default_rng() is the intended (and now also properly documented: https://github.com/JuliaLang/julia/pull/44733) way to obtain the default RNG.

codecov[bot] commented 2 years ago

Codecov Report

Merging #104 (a954259) into master (346c6a2) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files           7        7           
  Lines         271      271           
=======================================
  Hits          265      265           
  Misses          6        6
Impacted Files Coverage Δ
src/sample.jl 97.66% <100.00%> (ø)
src/stepper.jl 100.00% <100.00%> (ø)
src/transducer.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b75d15...a954259. Read the comment docs.

devmotion commented 2 years ago

Seems CI doesn't like me :smile: The code and the tests seem fine, and the errors are not really reproducible (it's a different test that fails this time, and the downstream test seems to be a bit too strict and would require another tolerance or seed I assume).