Closed torfjelde closed 1 year ago
Do we still support Julia 1.3?
And we should at least be testing on Julia 1.6, which we currently are not doing.
Base: 97.19% // Head: 97.19% // No change to project coverage :thumbsup:
Coverage data is based on head (
314cb57
) compared to base (6ef1dcb
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
As long as you're happy with the bump to 1.6, this should now be ready to go:)
This PR adds an implementation of
AbstractModel
which supports the LogDensityProblems.jl interface.Benefits:
AbstractModel
, allowing sharing of model definitions between different sampler packages, e.g. with this AdvancedHMC.jl (see https://github.com/TuringLang/AdvancedHMC.jl/pull/301 for related discussion) and AdvancedMH.jl can both useLogDensityModel
instead of defining their own.