search

TuringLang / AbstractMCMC.jl

Abstract types and interfaces for Markov chain Monte Carlo methods
https://turinglang.org/AbstractMCMC.jl
MIT License
78 stars 18 forks source link

Do not test Atom/Juno #115

Closed devmotion closed 1 year ago

devmotion commented 1 year ago

This PR removes tests of progress logging with Atom/Juno since it holds back other test dependencies: The package is in maintenance-only mode and CompatHelper PRs are not merged anymore (see https://github.com/JunoLab/Atom.jl/pulls).

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.33% // Head: 97.33% // No change to project coverage :thumbsup:

Coverage data is based on head (3ca7b94) compared to base (33487da). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #115 +/- ## ======================================= Coverage 97.33% 97.33% ======================================= Files 8 8 Lines 300 300 ======================================= Hits 292 292 Misses 8 8 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

devmotion commented 1 year ago

To be clear, the PR didn't remove support for Juno (yet), we just don't test Juno anymore.

cpfiffer commented 1 year ago

I know! Just remarking that removing tests is probably a good idea anyway, following the general trend of Juno.