Open torfjelde opened 1 year ago
The default implementation of bundle_samples specializes on Vector{T}, which in becomes very annoying if you want to implement your own bundle_samples, e.g. if you then use AbstractVector you almost immediately run into ambiguity errors.
bundle_samples
Vector{T}
AbstractVector
https://github.com/TuringLang/AbstractMCMC.jl/blob/7192263f967b4a6bb1f78957c734a6a41c383026/src/interface.jl#L38-L44
In addition, IIUC it seems quite "useless" given that by default sample already returns a Vector of the transitions?
sample
Vector
Thoughts on removing this?
Do you have any thoughts on this @devmotion ?
The default implementation of
bundle_samples
specializes onVector{T}
, which in becomes very annoying if you want to implement your ownbundle_samples
, e.g. if you then useAbstractVector
you almost immediately run into ambiguity errors.https://github.com/TuringLang/AbstractMCMC.jl/blob/7192263f967b4a6bb1f78957c734a6a41c383026/src/interface.jl#L38-L44
In addition, IIUC it seems quite "useless" given that by default
sample
already returns aVector
of the transitions?Thoughts on removing this?