Closed devmotion closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.04
:tada:
Comparison is base (
e149f9f
) 97.33% compared to head (ffb7b43
) 97.37%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I'll have to dig out those examples; it's been a while. But will try to get around to it sometime today.
Were you able to find (and run?) the examples?
No, sorry haven't done it yet. The original examples in #120 are from MCMCTempering.jl which I haven't done in a while. This PR most certainly helps with the overall issue we've discussed, whether or not it actuallly solves the particular ambiguity I ran into.
Should we merge then maybe merge the PR and revisit #120 (or some variant) if problems show up again?
I'm happy with that:) I have NeurIPS reviews over the next few weeks, but once that's done I'll revisit MCMCTempering, and so might be able to provide some cases in #120 then :+1: But for now, let's just merge this.
Alternative to #120 which keeps the current functionality.
@torfjelde Do you have a MWE of the ambiguity issues? Or can confirm that this PR would fix the issues you ran into?