Closed torfjelde closed 10 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
d7c549f
) 97.37% compared to head (4dbcb3f
) 97.37%. Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
So I just removed _first_or_nothing
and added a simple check for the length of init_params
.
Though this is then a breaking change
@devmotion given that we're making a breaking change here, should we also throw in the renaming of init_params
to initial_params
as discussed in #119 ?
Aight, I'll merge this now, but let's delay the release until #119 has gone through to limit the number of breaking releases :+1:
But the PR here was marked as non-breaking anyway? π€ (I saw you already corrected the version bump π)
Wait, isn't minor version breaking?
And this will be breaking, since we no longer accept previously accepted input types.
On Mon, Oct 2, 2023, 3:29 PM David Widmann @.***> wrote:
But the PR here was marked as non-breaking anyway? π€ (I saw you already corrected the version bump π)
β Reply to this email directly, view it on GitHub https://github.com/TuringLang/AbstractMCMC.jl/pull/126#issuecomment-1743128102, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUPZZH42IWLLTNVAE74M6LX5LFWFAVCNFSM6AAAAAA4XHLHYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTGEZDQMJQGI . You are receiving this because you modified the open/close state.Message ID: @.***>
No, minor versions are only breaking < 1.0.0. The next breaking release will be 5.0.0.
Ooooooh, crap. I clearly work too much with < 1.0.0 packages :grimacing:
But aight, I'll bump to 5.0.0 then?
π
Fixes https://github.com/TuringLang/AbstractMCMC.jl/issues/125