TuringLang / AbstractMCMC.jl

Abstract types and interfaces for Markov chain Monte Carlo methods
https://turinglang.org/AbstractMCMC.jl
MIT License
78 stars 18 forks source link

Use _init_parmas for MCMCThreads and MCMCDistributed too #126

Closed torfjelde closed 10 months ago

torfjelde commented 11 months ago

Fixes https://github.com/TuringLang/AbstractMCMC.jl/issues/125

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d7c549f) 97.37% compared to head (4dbcb3f) 97.37%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #126 +/- ## ======================================= Coverage 97.37% 97.37% ======================================= Files 8 8 Lines 305 305 ======================================= Hits 297 297 Misses 8 8 ``` | [Files](https://app.codecov.io/gh/TuringLang/AbstractMCMC.jl/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang) | Coverage Ξ” | | |---|---|---| | [src/sample.jl](https://app.codecov.io/gh/TuringLang/AbstractMCMC.jl/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-c3JjL3NhbXBsZS5qbA==) | `96.64% <90.00%> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

torfjelde commented 11 months ago

So I just removed _first_or_nothing and added a simple check for the length of init_params.

Though this is then a breaking change

torfjelde commented 10 months ago

@devmotion given that we're making a breaking change here, should we also throw in the renaming of init_params to initial_params as discussed in #119 ?

torfjelde commented 10 months ago

Aight, I'll merge this now, but let's delay the release until #119 has gone through to limit the number of breaking releases :+1:

devmotion commented 10 months ago

But the PR here was marked as non-breaking anyway? πŸ€” (I saw you already corrected the version bump πŸ‘)

torfjelde commented 10 months ago

Wait, isn't minor version breaking?

And this will be breaking, since we no longer accept previously accepted input types.

On Mon, Oct 2, 2023, 3:29 PM David Widmann @.***> wrote:

But the PR here was marked as non-breaking anyway? πŸ€” (I saw you already corrected the version bump πŸ‘)

β€” Reply to this email directly, view it on GitHub https://github.com/TuringLang/AbstractMCMC.jl/pull/126#issuecomment-1743128102, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUPZZH42IWLLTNVAE74M6LX5LFWFAVCNFSM6AAAAAA4XHLHYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTGEZDQMJQGI . You are receiving this because you modified the open/close state.Message ID: @.***>

devmotion commented 10 months ago

No, minor versions are only breaking < 1.0.0. The next breaking release will be 5.0.0.

torfjelde commented 10 months ago

Ooooooh, crap. I clearly work too much with < 1.0.0 packages :grimacing:

But aight, I'll bump to 5.0.0 then?

devmotion commented 10 months ago

πŸ‘