Closed torfjelde closed 10 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
3ed5314
) 96.87% compared to head (c4471ad
) 97.37%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@torfjelde can you create a new branch from the previous non-breaking release, then make a new release there?
Also, I’m confused, v4.5 is a breaking release by semantic versioning, right?
No, 4.4.x to 4.5.0 is a non-breaking change. This is different from < 1.0.0 where 0.x to 0.x+1 is breaking.
BTW wouldn't it be better to just yank 4.5.0 from the registry instead of reverting and releasing?
BTW wouldn't it be better to just yank 4.5.0 from the registry instead of reverting and releasing?
Oh most definitely! How do we go about doing this?
Should we just merge #134 and make a release then? While we wait for 4.5.0 to be yanked?
Let's maybe wait ~2 hours to avoid merge conflicts in the registry? I pinged maintainers of the registry in https://julialang.slack.com/archives/C6M4DQA5P/p1698230734349069.
But in principle, yes, I think if the release is yanked we don't have to revert commits in AbstractMCMC but can just bump to 5.0.0 and release.
The release is yanked.
This supersedes #132, as in that PR I didn't do a proper
git revert
of all the commits.@yebai @devmotion