search

TuringLang / AbstractMCMC.jl

Abstract types and interfaces for Markov chain Monte Carlo methods
https://turinglang.org/AbstractMCMC.jl
MIT License
78 stars 18 forks source link

Reversion of commits v4.4.2..v4.5.0 #133

Closed torfjelde closed 10 months ago

torfjelde commented 10 months ago

This supersedes #132, as in that PR I didn't do a proper git revert of all the commits.

@yebai @devmotion

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3ed5314) 96.87% compared to head (c4471ad) 97.37%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #133 +/- ## ========================================== + Coverage 96.87% 97.37% +0.50% ========================================== Files 8 8 Lines 320 305 -15 ========================================== - Hits 310 297 -13 + Misses 10 8 -2 ``` | [Files](https://app.codecov.io/gh/TuringLang/AbstractMCMC.jl/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang) | Coverage Δ | | |---|---|---| | [src/AbstractMCMC.jl](https://app.codecov.io/gh/TuringLang/AbstractMCMC.jl/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-c3JjL0Fic3RyYWN0TUNNQy5qbA==) | `100.00% <ø> (ø)` | | | [src/sample.jl](https://app.codecov.io/gh/TuringLang/AbstractMCMC.jl/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang#diff-c3JjL3NhbXBsZS5qbA==) | `96.64% <95.00%> (+0.77%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yebai commented 10 months ago

@torfjelde can you create a new branch from the previous non-breaking release, then make a new release there?

yebai commented 10 months ago

Also, I’m confused, v4.5 is a breaking release by semantic versioning, right?

devmotion commented 10 months ago

No, 4.4.x to 4.5.0 is a non-breaking change. This is different from < 1.0.0 where 0.x to 0.x+1 is breaking.

devmotion commented 10 months ago

BTW wouldn't it be better to just yank 4.5.0 from the registry instead of reverting and releasing?

torfjelde commented 10 months ago

BTW wouldn't it be better to just yank 4.5.0 from the registry instead of reverting and releasing?

Oh most definitely! How do we go about doing this?

devmotion commented 10 months ago

https://github.com/JuliaRegistries/General/pull/94031

torfjelde commented 10 months ago

Should we just merge #134 and make a release then? While we wait for 4.5.0 to be yanked?

devmotion commented 10 months ago

Let's maybe wait ~2 hours to avoid merge conflicts in the registry? I pinged maintainers of the registry in https://julialang.slack.com/archives/C6M4DQA5P/p1698230734349069.

But in principle, yes, I think if the release is yanked we don't have to revert commits in AbstractMCMC but can just bump to 5.0.0 and release.

devmotion commented 10 months ago

The release is yanked.