search

TuringLang / AbstractMCMC.jl

Abstract types and interfaces for Markov chain Monte Carlo methods
https://turinglang.org/AbstractMCMC.jl
MIT License
87 stars 18 forks source link

Do not implement methods from Base #15

Closed devmotion closed 4 years ago

devmotion commented 4 years ago

IMO we should not implement these methods since we do not provide a useful default implementation and stuff like Base.hcat(c::AbstractChains...) = cat(c...; dims=2) will invalidate the default definition of hcat() in Base (which might be related to https://github.com/TuringLang/MCMCChains.jl/issues/171).

codecov[bot] commented 4 years ago

Codecov Report

Merging #15 into master will increase coverage by 7.24%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   80.85%   88.09%   +7.24%     
==========================================
  Files           1        1              
  Lines          47       42       -5     
==========================================
- Hits           38       37       -1     
+ Misses          9        5       -4
Impacted Files Coverage Δ
src/AbstractMCMC.jl 88.09% <ø> (+7.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca622ed...6d6c9db. Read the comment docs.