search

TuringLang / AbstractMCMC.jl

Abstract types and interfaces for Markov chain Monte Carlo methods
https://turinglang.org/AbstractMCMC.jl
MIT License
87 stars 18 forks source link

Fix module of progress logger #22

Closed devmotion closed 4 years ago

devmotion commented 4 years ago

When I updated Turing VI to use @ifwithprogresslogger as well I noticed a stupid bug which limits the reuse of the macro in other packages (currently it only works correctly when used inside of AbstractMCMC).

codecov[bot] commented 4 years ago

Codecov Report

Merging #22 into master will decrease coverage by 0.1%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   92.85%   92.75%   -0.11%     
==========================================
  Files           1        1              
  Lines          70       69       -1     
==========================================
- Hits           65       64       -1     
  Misses          5        5
Impacted Files Coverage Δ
src/AbstractMCMC.jl 92.75% <100%> (-0.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 685dc45...4d0013c. Read the comment docs.

devmotion commented 4 years ago

@cpfiffer Good to merge and release?