Closed devmotion closed 3 years ago
Merging #59 (8c9db50) into master (7e0967a) will decrease coverage by
0.39%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 98.68% 98.28% -0.40%
==========================================
Files 6 6
Lines 152 175 +23
==========================================
+ Hits 150 172 +22
- Misses 2 3 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/sample.jl | 99.10% <100.00%> (+0.08%) |
:arrow_up: |
src/logging.jl | 95.00% <0.00%> (-5.00%) |
:arrow_down: |
src/transducer.jl | 100.00% <0.00%> (ø) |
|
src/interface.jl | 95.00% <0.00%> (+2.14%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7e0967a...8c9db50. Read the comment docs.
I'm all for it, thanks!
This PR moves the
setprogress!
logic from Turing upstream. IMO it belongs here since it allows to tune the default keyword arguments. The change is non-breaking since the default is not changed and it can be specified in thesample
/mcmcsample
calls as before.Some additional background: The main reason for
mcmcsample
is that Turing wants to use different default keyword arguments forsample
but I guess it might be better to allow to set or define the keyword arguments instead. E.g., by adding an additionaldefault_chain_type(model, sampler) = Any
function that could be implemented asdefault_chain_type(::Model, ::Sampler{<:InferenceAlgorithm}) = Chain
in Turing.