search

TuringLang / AbstractMCMC.jl

Abstract types and interfaces for Markov chain Monte Carlo methods
https://turinglang.org/AbstractMCMC.jl
MIT License
79 stars 18 forks source link

Use TerminalLoggers also on Windows for Julia >= 1.5.3 #61

Closed devmotion closed 3 years ago

devmotion commented 3 years ago

It seems TerminalLoggers can be used for rendering progress bars on Windows with recent versions of Julia: https://c42f.github.io/TerminalLoggers.jl/dev/#Progress-bars-1

I don't have access to a computer with Windows, so it would be good if someone could confirm that it works fine before merging the PR.

codecov[bot] commented 3 years ago

Codecov Report

Merging #61 (c82b9d5) into master (1474452) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files           6        6           
  Lines         191      191           
=======================================
  Hits          188      188           
  Misses          3        3
Impacted Files Coverage Δ
src/logging.jl 95.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1474452...c82b9d5. Read the comment docs.

cpfiffer commented 3 years ago

I don't have windows either! Might just merge this through anyways since the change is fairly minor.