search

TuringLang / AbstractMCMC.jl

Abstract types and interfaces for Markov chain Monte Carlo methods
https://turinglang.org/AbstractMCMC.jl
MIT License
87 stars 18 forks source link

Testing new progress bars #83

Closed kaandocal closed 1 year ago

kaandocal commented 3 years ago

This is a proposed fix for #82 (definitely WIP). I created variants of some ProgressLogging macros that can be used to add children to the current progress bar, see src/logging.jl; these probably belong elsewhere. The main progress bar showing the # of chains completed is still there, but it might make more sense to update it with the avg. % of work done on each process (that will render the ETA more helpful).

I don't have experience with Distributed so some slight modifications might be needed in that case.

EDIT: Any opinions about ProgressMeter.jl?

devmotion commented 3 years ago

EDIT: Any opinions about ProgressMeter.jl?

We replaced it with ProgressLogging 😛 The main advantage of ProgressLogging is that it uses the Julia logging system and works with different frontends (eg TerminalLogger, ConsoleProgressMonitor, Juno, VSCode). However, there are still things missing/unpolished in the ProgressLogging API, as the references in the linked issue show, and some things are not supported by the loggers.