search

TuringLang / AbstractPPL.jl

Common types and interfaces for probabilistic programming
http://turinglang.org/AbstractPPL.jl/
MIT License
27 stars 7 forks source link

Add CI tests and CompatHelper #16

Closed devmotion closed 3 years ago

devmotion commented 3 years ago

In addition to this PR, one has to add a SSH deploy key (e.g., by following the instructions here: https://github.com/JuliaRegistries/CompatHelper.jl#122-instructions-for-setting-up-the-ssh-deploy-key) to allow CompatHelper to trigger the CI tests.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6b954e6). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage        ?   81.03%           
=======================================
  Files           ?        1           
  Lines           ?       58           
  Branches        ?        0           
=======================================
  Hits            ?       47           
  Misses          ?       11           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b954e6...6c51fc4. Read the comment docs.

phipsgabler commented 3 years ago

LGTM as far as I can judge, but I'm not really familiar with GitHub workflows. I have added the deploy key, can you check if it works correctly?

devmotion commented 3 years ago

Unfortunately, I don't think it's possible to check it - we have to wait until CompatHelper runs or trigger it manually once the action is available in the default branch.