Minor performance issue with `Setfield`

TuringLang / AbstractPPL.jl

Common types and interfaces for probabilistic programming

http://turinglang.org/AbstractPPL.jl/

MIT License

27 stars 7 forks source link

Closed yebai closed 3 years ago

yebai commented 3 years ago

phipsgabler commented 3 years ago

The reason is the default hash method for lenses, see https://github.com/jw3126/Setfield.jl/issues/161.

phipsgabler commented 3 years ago

@torfjelde could you check the benchmarks again with Setfield 0.8.0, as soon as it's out?

phipsgabler commented 3 years ago

Ping @torfjelde

torfjelde commented 3 years ago

It's indeed fixed:)