TuringLang / AbstractPPL.jl

Common types and interfaces for probabilistic programming

MIT License

27 stars 7 forks source link

Clean-up for new release #31

Closed torfjelde closed 3 years ago

torfjelde commented 3 years ago

There was some minor left-over work from the lens-PR. This PR does that work. AFAIK we should be good for a release after this.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1217664546

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

9 of 14 (64.29%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.778%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/varname.jl	9	14	64.29%
<!--	Total:	9	14	64.29%	-->

Totals
Change from base Build 1151082486:	0.0%
Covered Lines:	84
Relevant Lines:	108

💛 - Coveralls

codecov[bot] commented 3 years ago

Codecov Report

Merging #31 (c6e8625) into main (33f896c) will not change coverage. The diff coverage is 64.28%.

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files           1        1           
  Lines         108      108           
=======================================
  Hits           84       84           
  Misses         24       24

Impacted Files	Coverage Δ
src/varname.jl	`77.77% <64.28%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33f896c...c6e8625. Read the comment docs.

torfjelde commented 3 years ago

This should be a pretty quick review btw; only renaming somethings:)