TuringLang / AbstractPPL.jl

Common types and interfaces for probabilistic programming
http://turinglang.org/AbstractPPL.jl/
MIT License
27 stars 7 forks source link

Backport 3-arg `rand` to AbstractPPL 0.5.x #80

Closed sunxd3 closed 1 year ago

sunxd3 commented 1 year ago

rand defaults have been added since AbstractPPL v0.6.2 (#79), backporting to v0.5 for compatibility.

yebai commented 1 year ago

Thanks, @sunxd3 -- it looks good; feel free to merge once CI passes.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (releases-0.5.x@d6d898b). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## releases-0.5.x #80 +/- ## ================================================= Coverage ? 81.02% ================================================= Files ? 3 Lines ? 274 Branches ? 0 ================================================= Hits ? 222 Misses ? 52 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TuringLang)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

devmotion commented 1 year ago

For future backports, a common approach (that we use e.g. also in SpecialFunctions) is to cherry-pick the relevant commit. See e.g. https://github.com/JuliaLang/julia/blob/a77ba79855f400420ccaa09c153ecec2784e386e/doc/src/devdocs/build/distributing.md#cherry-picking-commits for an explanation. The advantage is that one can then resolve conflicts similar to merges and git copies information such as the original commit message and contributors.

sunxd3 commented 1 year ago

The changes were done by local git cherry-pick, somehow the original commit information was lost still, I'll verify next time.