search

TuringLang / AbstractPPL.jl

Common types and interfaces for probabilistic programming
http://turinglang.org/AbstractPPL.jl/
MIT License
24 stars 6 forks source link

Remove MacroTools #92

Closed yebai closed 5 months ago

yebai commented 5 months ago

Related: https://github.com/JuliaRegistries/General/pull/103811#issuecomment-2025838678

yebai commented 5 months ago

The following lines require MacroTools.capture. Can these lines be rewritten to avoid the dependency on MacroTools? If such a rewrite requires a substantial effort, we can add MacroTools as a dependency.

https://github.com/TuringLang/AbstractPPL.jl/blob/f3fbce0932030372d0a7bca1325f78792583395d/src/varname.jl#L692

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.20%. Comparing base (b342b3d) to head (76ace06). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #92 +/- ## ========================================== + Coverage 84.82% 88.20% +3.37% ========================================== Files 3 3 Lines 145 178 +33 ========================================== + Hits 123 157 +34 + Misses 22 21 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sunxd3 commented 5 months ago

Yep, Accessors depends on MacroTools, we can just use it as a bridge.

sunxd3 commented 5 months ago

All good suggestions, thanks @devmotion!