Closed xukai92 closed 3 years ago
CI passed now and it's ready for a final look @yebai
The only CI which "fails" due to running out of time. For some reaon the Geweke tests are pretty slow on Julia 1.0 (>4h) vs nightly (~1.5h). I check previous CI logs and this was true before (this PR) as well.
To be safe I just triggered a re-run of all CI. Let's see how it goes this time.
Is this good to go?
This PR unifies all trajectories under the same interface. For example, NUTS shall be constructed by:
Old constructors are supported but deprecated.
Besides, the way to unify
FixedNSteps
andFixedIntegrationTime
is via a new-introducednsteps(::Trajectory)
, suggested by @torfjelde.FixedIntegrationTime
was converted toFixedNSteps
before callingtransition
, andtermination_criterion.L
appears here and there, which is not ideal.