TuringLang / AdvancedHMC.jl

Robust, modular and efficient implementation of advanced Hamiltonian Monte Carlo algorithms
https://turinglang.org/AdvancedHMC.jl/
MIT License
237 stars 41 forks source link

Unify argument orders #248

Open xukai92 opened 3 years ago

xukai92 commented 3 years ago

Currently the order of internal functions on the hamiltonian, phasepoint, kernel/trajectory are not all consistent. We should make all of them having a order of (rng, hamiltonian, kernel, z).

Also see https://github.com/TuringLang/AdvancedHMC.jl/pull/247/files#r579401575