search

TuringLang / AdvancedHMC.jl

Robust, modular and efficient implementation of advanced Hamiltonian Monte Carlo algorithms
https://turinglang.org/AdvancedHMC.jl/
MIT License
237 stars 41 forks source link

Broken link in README #256

Closed treigerm closed 1 year ago

treigerm commented 3 years ago

The link in the second sentence of the parallel sampling sentence points to a webpage which does not seem to exist (https://turing.ml/dev/docs/library/advancedhmc/parallel_sampling). Is this a page that is supposed to be added for the standalone docs?

xukai92 commented 3 years ago

That might be updated to https://turing.ml/dev/docs/using-turing/guide#sampling-multiple-chains. But this link is no longer informative to AHMC users, as many of the patterns have been built into AbstractMCMC now and users doesn't need to write from scratch any more if using Turing directly.

treigerm commented 3 years ago

The link is supposed to give information about vectorized sampling as the full sentence says:

It also supports vectorized sampling for static HMC and has been discussed in more detail in the documentation here.

Is the vectorized sampling already available for Turing and does AbstractMCMC have an interface for it?

xukai92 commented 3 years ago

Is the vectorized sampling already available for Turing and does AbstractMCMC have an interface for it?

No.

IIRC that part was written by @Vaibhavdixit02. Can you remind us what was that supposed to link to?

Vaibhavdixit02 commented 3 years ago

Yeah that was supposed to get a separate page in the docs, I think my unfinished PR might have the structure of what it was

yebai commented 1 year ago

This is likely fixed now.