Minor fix: missing `rng` for `init_params`

TuringLang / AdvancedHMC.jl

Robust, modular and efficient implementation of advanced Hamiltonian Monte Carlo algorithms

https://turinglang.org/AdvancedHMC.jl/

MIT License

228 stars 39 forks source link

Closed theogf closed 2 years ago

sethaxen commented 2 years ago

It would be nice also to have a test that would have broken before but now passes.

theogf commented 2 years ago

@sethaxen Do you have something in mind?

xukai92 commented 2 years ago

I think it could be as simple as sampling twice with the same rng (for a very short chain) and check if the samples are exactly the same.

sethaxen commented 2 years ago

I agree, we should have had that test anyways.

theogf commented 2 years ago

Sorry the test I added was incorrect, it should be fixed now

theogf commented 2 years ago

@sethaxen @xukai92 Is there anything missing from this PR?