search

TuringLang / AdvancedHMC.jl

Robust, modular and efficient implementation of advanced Hamiltonian Monte Carlo algorithms
https://turinglang.org/AdvancedHMC.jl/
MIT License
237 stars 41 forks source link

CompatHelper: bump compat for StatsFuns to 1, (keep existing compat) #289

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

This pull request changes the compat entry for the StatsFuns package from 0.8, 0.9 to 0.8, 0.9, 1. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

andreasnoack commented 2 years ago

@yebai @xukai92 would you be okay with a patch release to make this one available? It would unblock StatsFuns@1 for us.

yebai commented 2 years ago

@andreasnoack That sounds good - please feel free to open a PR to bump the version.

yebai commented 2 years ago

By the way, what are the breaking changes in StatsFun 1.0?

andreasnoack commented 2 years ago

Thanks.

By the way, what are the breaking changes in StatsFun 1.0?

On Julia version < 1.3, it broke the beta and gamma CDFs. Nothing should be breaking on more recent versions. Only issue seems to be https://github.com/JuliaStats/StatsFuns.jl/issues/133#issuecomment-1069602721. I've tried to come up with a fix, but it's a pretty extreme corner case to handle.