search

TuringLang / AdvancedHMC.jl

Robust, modular and efficient implementation of advanced Hamiltonian Monte Carlo algorithms
https://turinglang.org/AdvancedHMC.jl/
MIT License
228 stars 39 forks source link

Convinience constructors #325

Closed JaimeRZP closed 1 year ago

JaimeRZP commented 1 year ago

Fix #314. Fix https://github.com/TuringLang/AdvancedHMC.jl/issues/313

JaimeRZP commented 1 year ago

Hi @devmotion!

Thank you a lot for having a look at this! I think the approach you are suggesting is very similar to what I origally proposed in this commit. After some back and forth with @torfjelde we ended up going down this route but maybe we should have a call about it all the three of us?

torfjelde commented 1 year ago

I think the design mixes up the notion of algorithms and samplers. IMO algorithms should not be AbstractSamplers.

But do we want to keep the idea of an "algorithm" around? What's the motivation?

torfjelde commented 1 year ago

This is looking good @JaimeRZP :) Will have a proper look on Friday :+1: