Closed JaimeRZP closed 1 year ago
Thanks a lot @torfjelde. All good my plan is to merge this and make a release so we can bump the version on Turing!
Good stuff:) Added a few comments.
Also, have we added docs (not in the README, but in
docs/
) for this?IMO we should just move all the stuff in the README to
docs/
anyways, though this should be done in a separate PR (but in this scenario, it might be worth just moving the section on the convenience contsructors todocs/
maybe?)
Made an issue about it #330
Updated ReadMe to explain how to use the constructors. I also spotted a bug in the latest PR and added some tests so it doesn't go unnoticed in the future.