TuringLang / Bijectors.jl

Implementation of normalising flows and constrained random variable transformations
https://turinglang.org/Bijectors.jl/
MIT License
200 stars 33 forks source link

rand call to dist of MvTransformed not using rng #135

Closed JobJob closed 4 years ago

JobJob commented 4 years ago

Minor thing I noticed:

https://github.com/TuringLang/Bijectors.jl/blob/a3ece9122b8e1c9aa3f81105f6a384d85a09e856/src/transformed_distribution.jl#L134

should be:

res = hcat([td.transform(rand(rng, td.dist)) for i = 1:num_samples]...)
torfjelde commented 4 years ago

Ah, nice catch @JobJob !