Update to ChainRulesCore 0.10

TuringLang / Bijectors.jl

Implementation of normalising flows and constrained random variable transformations

https://turinglang.org/Bijectors.jl/

MIT License

200 stars 33 forks source link

Update to ChainRulesCore 0.10 #182

Closed devmotion closed 3 years ago

devmotion commented 3 years ago

Supercedes https://github.com/TuringLang/Bijectors.jl/pull/180 and https://github.com/TuringLang/Bijectors.jl/pull/181.

devmotion commented 3 years ago

Test errors are caused by NNlib it seems - I don't understand why we end up with such an old version (0.7.9), IIRC the problem is fixed in recent versions of NNlib.

devmotion commented 3 years ago

Ah OK, so 0.7.9 was the latest release without explicit ChainRules dependency: ChainRulesCore 0.10 is pulled in first and since no more recent version of NNlib is compatible with it (well, 0.7.21 is but it requires Julia >= 1.6) the old version with the bug is installed. I'll try to force NNlib 0.7.18 explicitly (latest release which supports ChainRulesCore 0.9 + Julia 1.3).

yebai commented 3 years ago

Many thanks, @devmotion.