Added `output_length` and `output_size`

TuringLang / Bijectors.jl

Implementation of normalising flows and constrained random variable transformations

https://turinglang.org/Bijectors.jl/

MIT License

196 stars 32 forks source link

Added `output_length` and `output_size` #270

Closed torfjelde closed 1 year ago

torfjelde commented 1 year ago

This is needed to ensure that transformed distributions are handled correctly now that transformations can change the support.

Related: #265

torfjelde commented 1 year ago

Cheers @devmotion ! I did all your suggestions + removed output_length due to it's limited use. Also added more descriptive error :+1:

torfjelde commented 1 year ago

I'm fixing Stacked atm and I think that should probably go in this PR otherwise it'll buggy.

torfjelde commented 1 year ago

Would be nice to get this merged somewhat quickly if there's nothing signficant holding it back, as everything related to "proper support for contrainsted distributions in Turing" is held back by this :grimacing:

Note that the Stacked really needs a rework, as have been noted many times before, but I don't think we should do that now.

torfjelde commented 1 year ago

Awesome; thanks David! :heart: