search

TuringLang / Bijectors.jl

Implementation of normalising flows and constrained random variable transformations
https://turinglang.org/Bijectors.jl/
MIT License
196 stars 32 forks source link

Vector-version for `PDBijector` #271

Closed torfjelde closed 1 year ago

torfjelde commented 1 year ago

Similar vein to #246 and #263.

NOTE: This is based on #270 .

torfjelde commented 1 year ago

I made an issue to remind us that we should improve this implementation in the future. But for now I think we should just make it work, and then we can make it fast later.

torfjelde commented 1 year ago

Just pushing this once more: the release of 0.13 is just waiting for this PR. We should really get this in the same batch because it will technically be breaking. Otherwise we'll have to release 0.14 immediately after 0.13 :confused:

Could someone maybe just give it a quick look-over and hit approve? :grimacing: There really isn't anything controversial in here + it just reuses existing implementation.

torfjelde commented 1 year ago

Well shit. I messed up. My previous comment no longer holds true :grimacing:

torfjelde commented 1 year ago

Well shit. I messed up. My previous comment no longer holds true grimacing

Haha, I wanted to defer the release of Bijectors 0.13 until this had been merged, but in my excitement I forgot and made a release. Hence my comments regarding this above ain't no truth anymore :grimacing:

But I think just releasing this as 0.13.1 is fine so np :+1:

torfjelde commented 1 year ago

I believe comments have been addressed:)